WenyXu commented on issue #3737: URL: https://github.com/apache/incubator-opendal/issues/3737#issuecomment-1849524373
> > The incorrect metric is meaningless and misleads users to make decisions > > I can't see why the metric is incorrect: > > * Only one `Accessor::read` is sent: we got a reader. > * This reader will send muliple `read` and `seek` operations. > * They all collected correctly. Interesting, I must have missed something.... BTW, Assuming we have the following layers: ``` S3 ErrorContextLayer CompleteLayer (Returns the `Reader`) <--- The `Reader` we are talking about. Cache Retry Metrics ^ | | Requests ``` If we invoke the `reader_with` on the `accessor`, and the `Reader` returns from the `CompleteLayer`, the `self.inner.read()` seems didn't collected by the outside `Metrics`. It happened in our cases. cc @Taylor-lagrange Are there anything I missed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
