Xuanwo commented on issue #3737: URL: https://github.com/apache/incubator-opendal/issues/3737#issuecomment-1849537777
> If we invoke the `reader_with` on the `accessor`, and the `Reader` returns from the `CompleteLayer`, the invoking of `self.inner.read()` in the `Reader` isn't collected by the outside `Metrics`. It happened in our cases. cc @Taylor-lagrange Ok, I got your ideas. So the root cause here is not `self.inner.read()` not tracked. (It's by design, we don't want users to know our internal behavior.) The root cause is users can't track the metircs of `Reader::read()` and `Reader::seek()`. https://github.com/apache/incubator-opendal/blob/11faa19143d55099f23033f819433496d2528095/core/src/layers/metrics.rs#L775-L786 Take `Reader::read()` as an example, you want to know the duration and bytes of every read operations. I think we can address this via add metrics at reader level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
