weihanglo commented on code in PR #4061:
URL: https://github.com/apache/opendal/pull/4061#discussion_r1464080459
##########
core/Cargo.toml:
##########
@@ -250,8 +250,7 @@ reqwest = { version = "0.11.18", features = [
], default-features = false }
serde = { version = "1", features = ["derive"] }
serde_json = "1"
-# TODO: remove `rt` after https://github.com/apache/opendal/issues/3948
-tokio = { version = "1.27", features = ["sync", "rt"] }
+tokio = { version = "1.27", features = ["sync"] }
Review Comment:
[Feature
unification](https://doc.rust-lang.org/nightly/cargo/reference/features.html#feature-unification)
in Cargo is addition and there is no way to opt-out if any dependency in your
dependency closure activating a feature.
There is a pre-RFC might get this resolved, and we'd like to see people
drive it:
<https://internals.rust-lang.org/t/pre-rfc-mutually-excusive-global-features/19618>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
