Xuanwo commented on code in PR #4061:
URL: https://github.com/apache/opendal/pull/4061#discussion_r1464253034
##########
core/src/raw/tokio_util.rs:
##########
@@ -15,9 +15,10 @@
// specific language governing permissions and limitations
// under the License.
-use crate::*;
+use crate::{Error, ErrorKind};
/// Parse tokio error into opendal::Error.
-pub fn new_task_join_error(e: tokio::task::JoinError) -> Error {
+// HACK - tokio::task::JoinError is not always present, use an existential
type.
+pub fn new_task_join_error(e: impl Into<anyhow::Error>) -> Error {
Review Comment:
All services relying on `tokio::task::JoinError` must enable the
`internal-tokio-rt` feature instead. This feature is added for remove `impl
Into<anyhow::Error>` here, not for removing `tokio/rt` from more place.
> This feature is added for remove `impl Into<anyhow::Error>` here
I want this change to avoid `new_task_join_error` been used wrongly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
