suyanhanx commented on code in PR #4246:
URL: https://github.com/apache/opendal/pull/4246#discussion_r1498835375
##########
bindings/nodejs/package.json:
##########
@@ -1,7 +1,7 @@
{
"name": "opendal",
"author": "OpenDAL Contributors <[email protected]>",
- "version": "0.45.0",
Review Comment:
Why update this?
I don't think it should be named `x.y.z+core.a.b.c` where it relates to
distribution, i.e. the version of the package to be released to the
corresponding platform.
This looks so special. It's also very different from the user's daily use
case.
##########
bindings/nodejs/package.json:
##########
@@ -94,5 +94,14 @@
"registry": "https://registry.npmjs.org/";,
"access": "public"
},
- "packageManager": "[email protected]"
-}
+ "packageManager": "[email protected]",
+ "optionalDependencies": {
+ "@opendal/lib-win32-x64-msvc": "0.45.1+core.0.45.1",
+ "@opendal/lib-darwin-x64": "0.45.1+core.0.45.1",
+ "@opendal/lib-linux-x64-gnu": "0.45.1+core.0.45.1",
+ "@opendal/lib-darwin-arm64": "0.45.1+core.0.45.1",
+ "@opendal/lib-linux-arm64-gnu": "0.45.1+core.0.45.1",
+ "@opendal/lib-linux-arm64-musl": "0.45.1+core.0.45.1",
+ "@opendal/lib-win32-arm64-msvc": "0.45.1+core.0.45.1"
+ }
Review Comment:
Please remove this part.
##########
bindings/nodejs/package.json:
##########
@@ -1,7 +1,7 @@
{
"name": "opendal",
"author": "OpenDAL Contributors <[email protected]>",
- "version": "0.45.0",
Review Comment:
Let's just let the package be versioned freely. It's better to not add a
core version to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
