Xuanwo commented on code in PR #4246:
URL: https://github.com/apache/opendal/pull/4246#discussion_r1498850688


##########
bindings/nodejs/package.json:
##########
@@ -1,7 +1,7 @@
 {
   "name": "opendal",
   "author": "OpenDAL Contributors <[email protected]>",
-  "version": "0.45.0",

Review Comment:
   In the near future, version `0.45.3+core.0.55.0` will be released; we need 
to simplify how to identify the core version this package relies on.
   
   Most importantly, users can continue to write `^0.45` without any changes on 
their part.



##########
bindings/nodejs/package.json:
##########
@@ -94,5 +94,14 @@
     "registry": "https://registry.npmjs.org/";,
     "access": "public"
   },
-  "packageManager": "[email protected]"
-}
+  "packageManager": "[email protected]",
+  "optionalDependencies": {
+    "@opendal/lib-win32-x64-msvc": "0.45.1+core.0.45.1",
+    "@opendal/lib-darwin-x64": "0.45.1+core.0.45.1",
+    "@opendal/lib-linux-x64-gnu": "0.45.1+core.0.45.1",
+    "@opendal/lib-darwin-arm64": "0.45.1+core.0.45.1",
+    "@opendal/lib-linux-arm64-gnu": "0.45.1+core.0.45.1",
+    "@opendal/lib-linux-arm64-musl": "0.45.1+core.0.45.1",
+    "@opendal/lib-win32-arm64-msvc": "0.45.1+core.0.45.1"
+  }

Review Comment:
   DONE



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to