waynexia commented on code in PR #4735:
URL: https://github.com/apache/opendal/pull/4735#discussion_r1639481094


##########
core/src/services/s3/core.rs:
##########
@@ -765,6 +765,22 @@ pub struct CompleteMultipartUploadRequest {
     pub part: Vec<CompleteMultipartUploadRequestPart>,
 }
 
+/// Result of MultipartUploadRequest.
+///
+/// Result part on success are ignored.
+#[derive(Default, Debug, Deserialize, Eq, PartialEq)]
+#[serde(default, rename_all = "PascalCase")]
+pub struct CompleteMultipartUploadResult {
+    pub error: Vec<CompleteMultipartUploadResultError>,
+}

Review Comment:
   I only define the error parts to minimize the change. The body is discarded 
before so I assume its content doesn't matter. We can add a field in the future 
when we need it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to