waynexia commented on code in PR #4735:
URL: https://github.com/apache/opendal/pull/4735#discussion_r1639978060
##########
core/src/services/s3/writer.rs:
##########
@@ -158,7 +158,16 @@ impl oio::MultipartWrite for S3Writer {
let status = resp.status();
match status {
- StatusCode::OK => Ok(()),
+ StatusCode::OK => {
+ let (_, mut body) = resp.into_parts();
+ let bs = body.copy_to_bytes(body.remaining());
+ let result: CompleteMultipartUploadResult =
Review Comment:
I once tried to reuse `from_s3_error()` in `parse_error()` but it needs to
pass many local mutable variables as parameters. So I ended up making a new one
(though I suppose no other interface will need this special check on 200...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
