meteorgan commented on code in PR #4881:
URL: https://github.com/apache/opendal/pull/4881#discussion_r1675676089


##########
core/src/types/operator/operator_futures.rs:
##########
@@ -384,6 +395,16 @@ impl<F: Future<Output = Result<Writer>>> FutureWriter<F> {
     pub fn executor(self, executor: Executor) -> Self {
         self.map(|(args, options)| (args.with_executor(executor), options))
     }
+
+    /// Set the user defined metadata of the op
+    ///
+    /// ## Notes
+    ///
+    /// we don't need to include the user defined metadata prefix in the key
+    /// every service will handle it internally
+    pub fn user_metadata(self, data: HashMap<String, String>) -> Self {

Review Comment:
   Do you mean `IntoIterator` ?
   like this:
   ```
       pub fn user_metadata(self, data: impl IntoIterator<Item = (String, 
String)>) -> Self {
           self.map(|(args, options, bs)| 
(args.with_user_metadata(HashMap::from_iter(data)), options, bs))
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to