meteorgan commented on code in PR #4881:
URL: https://github.com/apache/opendal/pull/4881#discussion_r1675679880


##########
core/src/raw/http_util/header.rs:
##########
@@ -189,6 +190,45 @@ pub fn parse_into_metadata(path: &str, headers: 
&HeaderMap) -> Result<Metadata>
     Ok(m)
 }
 
+/// parse_metadata will parse http headers(including standards http headers
+/// and user defined metadata header) into Metadata.
+///
+/// # Arguments
+///
+/// * `user_metadata_prefix` is the prefix of user defined metadata key
+///
+/// # Notes
+///
+/// before return the user defined metadata, we'll strip the 
user_metadata_prefix from the key
+pub fn parse_metadata(

Review Comment:
   It may seem like premature optimization, but the user meta prefix is used in 
other services, such as S3 and GCS. but it's ok to do it later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to