erickguan commented on code in PR #5950:
URL: https://github.com/apache/opendal/pull/5950#discussion_r2027647453
##########
core/src/services/ipfs/backend.rs:
##########
@@ -435,7 +379,7 @@ impl DirStream {
impl oio::PageList for DirStream {
async fn next_page(&self, ctx: &mut oio::PageContext) -> Result<()> {
- let resp = self.backend.ipfs_list(&self.path).await?;
+ let resp = self.backend.core.ipfs_list(&self.path).await?;
Review Comment:
Can we reference `self.core` directly without going from `backend`?
Because you have `IpfsCore`, we can have:
```rust
pub struct DirStream {
core: Arc<IpfsCore>,
path: String,
}
```
##########
core/src/services/ipfs/backend.rs:
##########
@@ -93,6 +97,8 @@ impl IpfsBuilder {
///
/// This API is part of OpenDAL's Raw API. `HttpClient` could be changed
/// during minor updates.
+ #[deprecated(since = "0.53.0", note = "Use `Operator::update_http_client`
instead")]
Review Comment:
💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
