erickguan commented on code in PR #5950:
URL: https://github.com/apache/opendal/pull/5950#discussion_r2029422349
##########
core/src/services/ipfs/backend.rs:
##########
@@ -435,7 +379,7 @@ impl DirStream {
impl oio::PageList for DirStream {
async fn next_page(&self, ctx: &mut oio::PageContext) -> Result<()> {
- let resp = self.backend.ipfs_list(&self.path).await?;
+ let resp = self.backend.core.ipfs_list(&self.path).await?;
Review Comment:
Yes, you're right - we are depending on `IpfsBackend::stat`. Could we take
it a step further and build a function like `pub async fn
IpfsCore::ipfs_stat(name: &str) -> Result<Metadata>`? This would allow you to
retrieve metadata for each name directly via the core for `DirStream`.
As aside, while this change improves the structure, it doesn't resolve the
N+1 issue... That is not related to the issue. So we can ignore it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
