howardlau1999 commented on code in PR #6504:
URL: https://github.com/apache/opendal/pull/6504#discussion_r2269434510
##########
core/src/services/oss/backend.rs:
##########
@@ -104,6 +104,13 @@ impl OssBuilder {
self
}
+ /// Set addressing style for the endpoint.
+ pub fn addressing_style(mut self, addressing_style: &str) -> Self {
Review Comment:
As documented in the official docs, there are three addressing style
available, so I think a boolean switch may be insufficient.
##########
core/src/services/oss/backend.rs:
##########
@@ -104,6 +104,13 @@ impl OssBuilder {
self
}
+ /// Set addressing style for the endpoint.
+ pub fn addressing_style(mut self, addressing_style: &str) -> Self {
Review Comment:
As documented in the official docs, there are three addressing styles
available, so I think a boolean switch may be insufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
