howardlau1999 commented on code in PR #6504:
URL: https://github.com/apache/opendal/pull/6504#discussion_r2269745924
##########
core/src/services/oss/backend.rs:
##########
@@ -104,6 +104,13 @@ impl OssBuilder {
self
}
+ /// Set addressing style for the endpoint.
+ pub fn addressing_style(mut self, addressing_style: &str) -> Self {
Review Comment:
> How about an enum?
I was using an enum at first but it seems that the config parser does not
support parsing enums so I changed this to a string. Do you have better
suggestions?
https://github.com/apache/opendal/commit/72bf31203575f475f2718fcc23f7404ccd980a3d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
