erickguan commented on code in PR #6683: URL: https://github.com/apache/opendal/pull/6683#discussion_r2437224209
########## core/src/services/gdrive/core.rs: ########## Review Comment: Remove since unused. ########## core/src/services/gdrive/core.rs: ########## Review Comment: ```suggestion /// File struct for Google Drive API /// We select a few arbitrary fields. /// When update fields, keep `DRIVE_FILE_FIELDS` in sync to fetch related data. /// Read more [here](https://developers.google.com/drive/api/reference/rest/v3/files#File) ``` ########## core/src/services/gdrive/core.rs: ########## Review Comment: This comment is outdated. I recommend adding these at the top of core. ```rust // we append this as part of URL to request Google Drive file fields // must be sync with `GdriveFile` struct fields // read more [here](https://developers.google.com/workspace/drive/api/guides/fields-parameter) pub(crate) const DRIVE_FILE_FIELDS: &'static str = "id,size,modifiedTime,md5Checksum,version"; ``` Then this can be used when needed when building URLs in `format!()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
