erickguan commented on code in PR #6683: URL: https://github.com/apache/opendal/pull/6683#discussion_r2437305558
########## core/src/services/gdrive/core.rs: ########## Review Comment: See a comment above near the top of the core. Here is a design choice how to keep the fields and requested data in sync. On the spectrum, - prefer consistency? Then we use more `String` in the model - prefer lower amount of allocations? Then we use more `Option<String>`. What do you think about this design choice? My reasoning is that Google probably loads some metadata in memory so I would always requests some data, like `id`, `name`, `size`, `modified_time`. Fine to keep `md5_checksum` and `version` as optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
