Xuanwo commented on code in PR #6765: URL: https://github.com/apache/opendal/pull/6765#discussion_r2509527919
########## core/src/services/aliyun_drive/mod.rs: ########## @@ -16,7 +16,7 @@ // under the License. /// Default scheme for aliyun_drive service. -pub const ALIYUN_DRIVE_SCHEME: &str = "aliyun-drive"; +pub const ALIYUN_DRIVE_SCHEME: &str = "aliyun_drive"; Review Comment: I think it's better to keep the `aliyun-drive` as scheme since `_` is not allowed in spec: https://developer.mozilla.org/en-US/docs/Web/URI/Reference/Schemes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
