koushiro commented on code in PR #6765: URL: https://github.com/apache/opendal/pull/6765#discussion_r2511151001
########## core/src/services/aliyun_drive/mod.rs: ########## @@ -16,7 +16,7 @@ // under the License. /// Default scheme for aliyun_drive service. -pub const ALIYUN_DRIVE_SCHEME: &str = "aliyun-drive"; +pub const ALIYUN_DRIVE_SCHEME: &str = "aliyun_drive"; Review Comment: I unified the connectors in the scheme string to `-`. There are some errors in the behavior tests/core in CI, because now we have started using a string-based scheme. However, the current minimoka service uses `mini-moka` as the scheme, while the `test_behavior_core.yml` workflow uses the name from `".github/services/mini_moka/mini_moka"` to set the `OPENDAL_TEST` env variable. @Xuanwo Do you think I should rename these path names in `.github/services`, or modify the script in the workflow to replace `_` with `-` in the scheme string passed via the `OPENDAL_TEST` env variable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
