Xuanwo commented on code in PR #7128:
URL: https://github.com/apache/opendal/pull/7128#discussion_r2659478763


##########
bindings/java/src/main/java/org/apache/opendal/layer/LoggingLayer.java:
##########
@@ -24,6 +24,9 @@
 /**
  * This layer adds structured logging for every operation.
  *
+ * <p>Note: This layer requires proper logging setup (e.g., log4j2, 
java.util.logging) to work.

Review Comment:
   Hi, please understand your changes first. `LoggingLayer` integrate rust's 
`log` crate and thus requires we to provide a `set_logger` call. Users can't 
configure that through `log4j2` or `java.util.logging`.
   
   Maybe we can start a discussion thread on how we do that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to