Retrospection commented on code in PR #7128:
URL: https://github.com/apache/opendal/pull/7128#discussion_r2663342563


##########
bindings/java/src/main/java/org/apache/opendal/layer/LoggingLayer.java:
##########
@@ -24,6 +24,9 @@
 /**
  * This layer adds structured logging for every operation.
  *
+ * <p>Note: This layer requires proper logging setup (e.g., log4j2, 
java.util.logging) to work.

Review Comment:
   Sorry for rough pr. 
   
   Honestly I'm not that familiar with this binding layer, and just think this 
can be implemented with ai just because it has other language implementation as 
reference.
   
   I'll do some research to understand what the binding layer is for and then 
do discussion about implementation.
   
   Thanks for kindly review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to