jeevaprakashdr commented on code in PR #7114:
URL: https://github.com/apache/opendal/pull/7114#discussion_r2818229446
##########
core/services/onedrive/src/lister.rs:
##########
@@ -29,6 +29,32 @@ use super::graph_model::GENERAL_SELECT_PARAM;
use super::graph_model::GraphApiOneDriveListResponse;
use super::graph_model::ItemType;
+// --- Helper Function for URL Generation (Logic Extracted Here) ---
+// We use a closure `item_url_fn` to mock the behavior of `onedrive_item_url`
+// so we can test this without a real OneDriveCore instance.
+fn build_request_url(
+ token: &str,
+ path: &str,
+ limit: Option<usize>,
+ item_url_fn: impl Fn(&str) -> String,
+) -> String {
+ if !token.is_empty() {
+ return token.to_string();
+ }
+
+ let base = if path == "/" {
+ format!("/me/drive/root/children?{}", GENERAL_SELECT_PARAM)
Review Comment:
this expression is missing `API Root`. If path is "/" this will only
return relative path and not fully qualified url.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
