Xuanwo commented on code in PR #7815:
URL: https://github.com/apache/opendal/pull/7815#discussion_r3458702081
##########
core/services/hdfs/src/config.rs:
##########
@@ -45,6 +45,10 @@ pub struct HdfsConfig {
pub enable_append: bool,
/// atomic_write_dir of this backend
pub atomic_write_dir: Option<String>,
+ /// Whether HDFS rename should overwrite an existing target file.
Review Comment:
I think this feature is focusing on the wrong thing. The semantics of
OpenDAL are clear: rename should overwrite, just like the file system does.
Therefore, HDFS should not alter the behavior itself. Instead, it should:
- Enable the atomic rename if HDFS supports it
- Fall back to delete-then-rename if HDFS does not support it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
