hfutatzhanghb commented on code in PR #7815:
URL: https://github.com/apache/opendal/pull/7815#discussion_r3458767166
##########
core/services/hdfs/src/config.rs:
##########
@@ -45,6 +45,10 @@ pub struct HdfsConfig {
pub enable_append: bool,
/// atomic_write_dir of this backend
pub atomic_write_dir: Option<String>,
+ /// Whether HDFS rename should overwrite an existing target file.
Review Comment:
Actually, HDFS supports atomic rename and suggests to use Options.Rename to
perform rename operations which are defined as below:
https://github.com/apache/hadoop/blob/10bb684bb4d5cb8edbd2ce79a5d695592cef32c5/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Options.java#L226
IIUC, should i add a new operation interface `atomic_rename_if_not_exists`
here and use it in lance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
