[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085413#comment-17085413
 ] 

Sebastian Wagner commented on OPENMEETINGS-2247:
------------------------------------------------

Cool. I was looking at the same link. But then this ticket is 2 years old. And 
the linked test suggests Safari is fixed now.

Could we move the method ConfigurationDao::updateCsp(...)

into the openmeetings-web project ?

openmeetings-db should ideally only do DB stuff. And openmeetings-web can load 
the config using the DAO. But mixing CSP headers into the openmeetings-db 
project, I think its bit confusing. The DB project shouldn't need wicket 
dependencies. :)

Also IApplication, shouldn't the interface be in the same package like the 
Application.java ? 

> CSP should be re-worked
> -----------------------
>
>                 Key: OPENMEETINGS-2247
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2247
>             Project: Openmeetings
>          Issue Type: Task
>          Components: Builds, UI
>    Affects Versions: 5.0.0-M4
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Major
>             Fix For: 5.0.0-M4
>
>         Attachments: image-2020-04-17-14-37-11-501.png, 
> image-2020-04-17-14-59-08-307.png, image-2020-04-17-15-16-37-187.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Previously CSP was implemented via 
> {{header.csp.frame.options}} and {{header.content.security.policy}}
> https://openmeetings.apache.org/GeneralConfiguration.html
> Above setting were applied here 
> https://github.com/apache/openmeetings/blob/5.0.0-M3/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java#L244
> This should be re-worked



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to