[
https://issues.apache.org/jira/browse/OPENMEETINGS-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086174#comment-17086174
]
Maxim Solodovnik commented on OPENMEETINGS-2247:
------------------------------------------------
I believe this discussion about code need to be moved somewhere else :)))
When I'm saying cached and static I mean here
https://github.com/apache/openmeetings/blob/master/openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java#L122
These values are updated on every edit of config value
There are much more
https://github.com/apache/openmeetings/blob/master/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java#L559
Updated values
The whole OM works under Wicket umbrella and the call to {{WebApplication.get}}
is guarded with
https://github.com/apache/openmeetings/blob/master/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java#L649
So it is safe
ConfigDao already have method
{code}
public List<Configuration> get(String... keys) {
{code}
The whole it's caching can be moved to some {{ConfigCache}} which will be in
{{DB}} module anyway
OR {{IConfigCache}} will be in {{DB}} so there will be no real re-coupling
Maybe you can suggest better solution?
(Unfortunately I see no benefit from just remove additional logic from
{{Repository}}, this is DB related code, it hides DB layer from other
application, and it seems to work :)))
> CSP should be re-worked
> -----------------------
>
> Key: OPENMEETINGS-2247
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2247
> Project: Openmeetings
> Issue Type: Task
> Components: Builds, UI
> Affects Versions: 5.0.0-M4
> Reporter: Maxim Solodovnik
> Assignee: Maxim Solodovnik
> Priority: Major
> Fix For: 5.0.0-M4
>
> Attachments: image-2020-04-17-14-37-11-501.png,
> image-2020-04-17-14-59-08-307.png, image-2020-04-17-15-16-37-187.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Previously CSP was implemented via
> {{header.csp.frame.options}} and {{header.content.security.policy}}
> https://openmeetings.apache.org/GeneralConfiguration.html
> Above setting were applied here
> https://github.com/apache/openmeetings/blob/5.0.0-M3/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java#L244
> This should be re-worked
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
