krickert commented on PR #1177:
URL: https://github.com/apache/opennlp/pull/1177#issuecomment-5029350750
All findings addressed as of 33285b4. Point by point:
**Blocking**
- *distr LICENSE*: added the `emoji-annotations.txt` entry; the distr NOTICE
comes from the already-updated template.
- *Null contract*: kept fail-loud IAE and added the missing `@throws`,
rather than downgrading to `requireNonNull`.
- *Commentary*: done, including the suggested phrasing. One condensed note
on `EmojiAnnotator`, copies deleted, the beyond-ASCII guard extracted into one
shared helper.
- *Constants*: mirrored the `EmojiEmoticons` constants; the split no longer
compiles a pattern per line.
- *Feature vocabulary*: fixed structurally rather than by renaming. Emission
now lives in one method, `EmojiAnnotator.collectFeatures(token, sink)`; the
generators are one-line delegations and the prefixes are private, so nothing is
left to drift. Unified dot-free names: `emojiSentiment=`, `emojiType=`,
`emojiCategory=`, `emojiRegion=`. Done now while 3.0 is unreleased since it
shrinks the public surface.
- *Javadoc*: factory constructors documented, overrides carry
`{@inheritDoc}` plus one sentence.
**Minor**
All applied: single lenient flag decode on the hot path,
`Collections.addAll` over `super.getContext`, the `(EmojiAnnotator)`
constructor seam on the sentiment generator, `isRegionalIndicator` made private
(its direct test folded into the `isoRegion`/`isFlag` coverage), the
lone-indicator message split into accurate cases, eager holder instead of DCL,
shared `cp()` test utility, parameterized malformed-input batteries,
`assertFalse` swaps, `Value` null tests, and the data-file header trimmed to
format plus provenance.
**Process**
Build green I'll run eval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
