krickert commented on PR #1177: URL: https://github.com/apache/opennlp/pull/1177#issuecomment-5033443083
All six addressed in 6d66ef7. Both generators now validate their arguments with the same fail-loud messages as the rest of the layer (pinned by tests), the two package-private data helpers carry full javadoc, and annotate() itself now short-circuits on the non-annotatable fast path via the existing guard, which also removed the duplicate check in collectFeatures. Good catch on the short circuit; it saves the lookup and the flag decode for every ordinary token. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
