krickert commented on code in PR #1462:
URL: https://github.com/apache/opennlp/pull/1462#discussion_r4243910169
##########
opennlp-core/opennlp-ml/opennlp-dl/src/test/java/opennlp/dl/vectors/OnnxTextEmbedderProviderTest.java:
##########
@@ -82,6 +82,17 @@ void testDoesNotSupportForeignOptionsOrLocations() {
assertThrows(IllegalArgumentException.class, () ->
provider.supports(null));
}
+ /**
+ * The provider has no option for a device yet, so a spec cannot select the
GPU and the
+ * embedder it creates runs on the CPU.
+ */
+ @ParameterizedTest
+ @ValueSource(strings = {"gpu", "gpuDeviceId", "device", "inferenceOptions"})
+ void testSpecCannotSelectTheGpu(final String option) {
Review Comment:
Removed. The manual states that the onnx provider spec has no device option
yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
