krickert commented on code in PR #1462:
URL: https://github.com/apache/opennlp/pull/1462#discussion_r4243920890
##########
opennlp-core/opennlp-ml/opennlp-dl-gpu/pom.xml:
##########
@@ -102,5 +109,31 @@
</plugins>
</build>
+ <!-- onnxruntime_gpu ships native libraries for linux-x64 and win-x64 only.
-->
+ <profiles>
+ <profile>
+ <id>no-onnxruntime-gpu-on-mac</id>
+ <activation>
+ <os>
+ <family>mac</family>
+ </os>
+ </activation>
+ <properties>
+ <skipTests>true</skipTests>
+ </properties>
+ </profile>
+ <profile>
+ <id>no-onnxruntime-gpu-on-aarch64</id>
Review Comment:
Done, the comment now reads: onnxruntime_gpu 1.30.0 ships native libraries
for linux-x64 and win-x64 only, unlike the CPU jar.
Had to change my mind on the two profiles: they only skip the tests, because
without those natives the module cannot load ONNX Runtime on macOS or aarch64
at all. Users on those platforms depend on opennlp-dl, which runs on the CPU
there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
