Copilot commented on code in PR #176:
URL: https://github.com/apache/otava/pull/176#discussion_r3887457570
##########
docs/GRAFANA.md:
##########
@@ -22,6 +22,14 @@
Change points found by `analyze` can be exported
as Grafana annotations using the `--update-grafana` flag:
+## Installation
Review Comment:
The new section interrupts the preceding sentence immediately after its
colon, leaving the usage example detached from that sentence. Put the
installation section before the usage introduction so the heading structure and
sentence read correctly.
##########
otava/influxdb.py:
##########
@@ -51,7 +64,7 @@ def __init__(self, config: InfluxDBConfig):
@property
def client(self) -> InfluxDBClient3:
if self._client is None:
- self._client = InfluxDBClient3(
+ self._client = _influxdb_client_class()(
Review Comment:
The missing-extra exception raised here is swallowed by
`InfluxDBImporter.fetch_data`'s blanket `except Exception`
(`otava/importer.py:876-879`) and rewrapped as `DataImportError`. `script_main`
catches that inside the per-test loop, so `otava analyze` without `[influxdb]`
logs the message but exits successfully instead of reaching the new
missing-dependency exit handler, unlike the other integrations. Re-raise
`MissingOptionalDependencyError` before the broad wrapper and cover the CLI
exit status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
