Gerrrr commented on code in PR #176:
URL: https://github.com/apache/otava/pull/176#discussion_r3888455440
##########
otava/influxdb.py:
##########
@@ -51,7 +64,7 @@ def __init__(self, config: InfluxDBConfig):
@property
def client(self) -> InfluxDBClient3:
if self._client is None:
- self._client = InfluxDBClient3(
+ self._client = _influxdb_client_class()(
Review Comment:
Fixed in f5cc644. `InfluxDBImporter.fetch_data` now re-raises
`MissingOptionalDependencyError` before its general client-error wrapper,
allowing the CLI handler to exit with status 1. Added a regression test
covering the exit status and actionable `[influxdb]` installation message.
##########
docs/GRAFANA.md:
##########
@@ -22,6 +22,14 @@
Change points found by `analyze` can be exported
as Grafana annotations using the `--update-grafana` flag:
+## Installation
Review Comment:
Fixed in f5cc644. The Installation section now comes first, and the usage
introduction remains directly attached to its command example under the Usage
heading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
