This is an automated email from the ASF dual-hosted git repository.
He-Pin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-connectors.git
The following commit(s) were added to refs/heads/main by this push:
new 31710fa21 refactor: use Java records and String.lines() (Java 11+/16+)
(#1723)
31710fa21 is described below
commit 31710fa212660f15e5c838a663dd59c814bd5633
Author: He-Pin(kerr) <[email protected]>
AuthorDate: Fri Jun 26 19:59:28 2026 +0800
refactor: use Java records and String.lines() (Java 11+/16+) (#1723)
* refactor: use Java records for simple data classes
Motivation:
Modernize test/example data holder classes using Java 16+ records
for cleaner, more concise code.
Modification:
Convert simple data classes (Animal, Person in geode tests) to records,
eliminating boilerplate constructors, getters, equals, hashCode, toString.
Result:
More concise, immutable-by-default data classes using Java records.
* fix(geode): use record accessor method references for Person/Animal
Motivation:
Person and Animal classes were migrated to Java records, which use
id() instead of getId() as the accessor method name. This caused a
compile error in GeodeBaseTestCase where Person::getId and Animal::getId
were used as method references for RegionSettings.create.
Modification:
Update method references from Person::getId and Animal::getId to
Person::id and Animal::id in GeodeBaseTestCase.
Result:
Geode module compiles successfully after the record migration.
---
geode/src/test/java/docs/javadsl/Animal.java | 26 ++--------------------
.../java/docs/javadsl/AnimalPdxSerializer.java | 6 ++---
.../test/java/docs/javadsl/GeodeBaseTestCase.java | 4 ++--
.../javadsl/GeodeContinuousSourceTestCase.java | 2 +-
geode/src/test/java/docs/javadsl/Person.java | 26 ++--------------------
.../java/docs/javadsl/PersonPdxSerializer.java | 6 ++---
.../src/test/java/docs/javadsl/HdfsWriterTest.java | 3 +--
7 files changed, 14 insertions(+), 59 deletions(-)
diff --git a/geode/src/test/java/docs/javadsl/Animal.java
b/geode/src/test/java/docs/javadsl/Animal.java
index add7740a1..d00d1c157 100644
--- a/geode/src/test/java/docs/javadsl/Animal.java
+++ b/geode/src/test/java/docs/javadsl/Animal.java
@@ -13,31 +13,9 @@
package docs.javadsl;
-public class Animal {
- private final int id;
- private final String name;
- private final int owner;
-
- public Animal(int id, String name, int owner) {
- this.id = id;
- this.name = name;
- this.owner = owner;
- }
-
- public int getId() {
- return id;
- }
-
- public String getName() {
- return name;
- }
-
- public int getOwner() {
- return owner;
- }
-
+public record Animal(int id, String name, int owner) {
@Override
public String toString() {
- return getId() + ": " + getName() + " owner: " + getOwner();
+ return id + ": " + name + " owner: " + owner;
}
}
diff --git a/geode/src/test/java/docs/javadsl/AnimalPdxSerializer.java
b/geode/src/test/java/docs/javadsl/AnimalPdxSerializer.java
index 1343ecca7..29b1df5ab 100644
--- a/geode/src/test/java/docs/javadsl/AnimalPdxSerializer.java
+++ b/geode/src/test/java/docs/javadsl/AnimalPdxSerializer.java
@@ -27,9 +27,9 @@ public class AnimalPdxSerializer implements
PekkoPdxSerializer<Animal> {
@Override
public boolean toData(Object o, PdxWriter out) {
if (o instanceof Animal p) {
- out.writeInt("id", p.getId());
- out.writeString("name", p.getName());
- out.writeInt("owner", p.getOwner());
+ out.writeInt("id", p.id());
+ out.writeString("name", p.name());
+ out.writeInt("owner", p.owner());
return true;
}
return false;
diff --git a/geode/src/test/java/docs/javadsl/GeodeBaseTestCase.java
b/geode/src/test/java/docs/javadsl/GeodeBaseTestCase.java
index 184ec757b..f7658b28d 100644
--- a/geode/src/test/java/docs/javadsl/GeodeBaseTestCase.java
+++ b/geode/src/test/java/docs/javadsl/GeodeBaseTestCase.java
@@ -47,9 +47,9 @@ public class GeodeBaseTestCase {
// #region
protected final RegionSettings<Integer, Person> personRegionSettings =
- RegionSettings.create("persons", Person::getId);
+ RegionSettings.create("persons", Person::id);
protected final RegionSettings<Integer, Animal> animalRegionSettings =
- RegionSettings.create("animals", Animal::getId);
+ RegionSettings.create("animals", Animal::id);
// #region
diff --git
a/geode/src/test/java/docs/javadsl/GeodeContinuousSourceTestCase.java
b/geode/src/test/java/docs/javadsl/GeodeContinuousSourceTestCase.java
index fd0b1b8ce..d29980f00 100644
--- a/geode/src/test/java/docs/javadsl/GeodeContinuousSourceTestCase.java
+++ b/geode/src/test/java/docs/javadsl/GeodeContinuousSourceTestCase.java
@@ -46,7 +46,7 @@ public class GeodeContinuousSourceTestCase extends
GeodeBaseTestCase {
.runForeach(
p -> {
LOGGER.debug(p.toString());
- if (p.getId() == 120) {
+ if (p.id() == 120) {
geode.closeContinuousQuery("test");
}
},
diff --git a/geode/src/test/java/docs/javadsl/Person.java
b/geode/src/test/java/docs/javadsl/Person.java
index 5e6a2f7db..0352489fe 100644
--- a/geode/src/test/java/docs/javadsl/Person.java
+++ b/geode/src/test/java/docs/javadsl/Person.java
@@ -15,31 +15,9 @@ package docs.javadsl;
import java.util.Date;
-public class Person {
- private final int id;
- private final String name;
- private final Date birthDate;
-
- public Person(int id, String name, Date birthDate) {
- this.id = id;
- this.name = name;
- this.birthDate = birthDate;
- }
-
- public int getId() {
- return id;
- }
-
- public String getName() {
- return name;
- }
-
- public Date getBirthDate() {
- return birthDate;
- }
-
+public record Person(int id, String name, Date birthDate) {
@Override
public String toString() {
- return getId() + ": " + getName();
+ return id + ": " + name;
}
}
diff --git a/geode/src/test/java/docs/javadsl/PersonPdxSerializer.java
b/geode/src/test/java/docs/javadsl/PersonPdxSerializer.java
index d359e283b..f0bb2f860 100644
--- a/geode/src/test/java/docs/javadsl/PersonPdxSerializer.java
+++ b/geode/src/test/java/docs/javadsl/PersonPdxSerializer.java
@@ -30,9 +30,9 @@ public class PersonPdxSerializer implements
PekkoPdxSerializer<Person> {
@Override
public boolean toData(Object o, PdxWriter out) {
if (o instanceof Person p) {
- out.writeInt("id", p.getId());
- out.writeString("name", p.getName());
- out.writeDate("birthDate", p.getBirthDate());
+ out.writeInt("id", p.id());
+ out.writeString("name", p.name());
+ out.writeDate("birthDate", p.birthDate());
return true;
}
return false;
diff --git a/hdfs/src/test/java/docs/javadsl/HdfsWriterTest.java
b/hdfs/src/test/java/docs/javadsl/HdfsWriterTest.java
index ed4dc2cad..893b3577e 100644
--- a/hdfs/src/test/java/docs/javadsl/HdfsWriterTest.java
+++ b/hdfs/src/test/java/docs/javadsl/HdfsWriterTest.java
@@ -282,8 +282,7 @@ public class HdfsWriterTest {
JavaTestUtils.verifyOutputFileSize(fs, logs);
assertEquals(
JavaTestUtils.readLogs(fs, logs).stream()
- .map(string -> string.split("\n"))
- .flatMap(Arrays::stream)
+ .flatMap(String::lines)
.collect(Collectors.toList()),
messagesFromKafka.stream().map(message ->
message.book.title).collect(Collectors.toList()));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
