This is an automated email from the ASF dual-hosted git repository.
He-Pin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko-connectors.git
The following commit(s) were added to refs/heads/main by this push:
new be0bb5d9f refactor: migrate switch statements to modern switch syntax
(Java 14+) (#1720)
be0bb5d9f is described below
commit be0bb5d9ff4d7715ee44aecdfa52e71cfcd698a4
Author: He-Pin(kerr) <[email protected]>
AuthorDate: Fri Jun 26 19:59:16 2026 +0800
refactor: migrate switch statements to modern switch syntax (Java 14+)
(#1720)
* refactor: migrate switch statements to modern switch syntax (Java 14+)
Motivation:
Java 14 introduced enhanced switch statements and switch expressions
with arrow syntax, eliminating fall-through bugs and reducing boilerplate.
Modification:
Convert switch statements to switch expressions and enhanced switch
statements in XmlParsingTest and BigQueryEndToEndTest.
Result:
Cleaner, more concise switch code with no fall-through risk.
* style: apply javafmt to fix code style check failure
Apply javafmt to BigQueryEndToEndTest.java in google-cloud-bigquery module.
---
.../bigquery/e2e/javadsl/BigQueryEndToEndTest.java | 20 ++++++-------
xml/src/test/java/docs/javadsl/XmlParsingTest.java | 33 +++++++++++-----------
2 files changed, 25 insertions(+), 28 deletions(-)
diff --git
a/google-cloud-bigquery/src/test/java/org/apache/pekko/stream/connectors/googlecloud/bigquery/e2e/javadsl/BigQueryEndToEndTest.java
b/google-cloud-bigquery/src/test/java/org/apache/pekko/stream/connectors/googlecloud/bigquery/e2e/javadsl/BigQueryEndToEndTest.java
index 57dbcd487..2cecbef36 100644
---
a/google-cloud-bigquery/src/test/java/org/apache/pekko/stream/connectors/googlecloud/bigquery/e2e/javadsl/BigQueryEndToEndTest.java
+++
b/google-cloud-bigquery/src/test/java/org/apache/pekko/stream/connectors/googlecloud/bigquery/e2e/javadsl/BigQueryEndToEndTest.java
@@ -139,18 +139,14 @@ public class BigQueryEndToEndTest extends EndToEndHelper {
.settings()
.config()
.getString("pekko.connectors.google.bigquery.test.e2e-mode")) {
- case "simulate":
- hoverfly.simulate(
- SimulationSource.url(
- BigQueryEndToEndTest.class
- .getClassLoader()
- .getResource("BigQueryEndToEndSpec.json")));
- break;
- case "capture":
- hoverfly.resetMode(HoverflyMode.CAPTURE);
- break;
- default:
- throw new IllegalArgumentException();
+ case "simulate" ->
+ hoverfly.simulate(
+ SimulationSource.url(
+ BigQueryEndToEndTest.class
+ .getClassLoader()
+ .getResource("BigQueryEndToEndSpec.json")));
+ case "capture" -> hoverfly.resetMode(HoverflyMode.CAPTURE);
+ default -> throw new IllegalArgumentException();
}
}
diff --git a/xml/src/test/java/docs/javadsl/XmlParsingTest.java
b/xml/src/test/java/docs/javadsl/XmlParsingTest.java
index 48ea8186b..27c03250b 100644
--- a/xml/src/test/java/docs/javadsl/XmlParsingTest.java
+++ b/xml/src/test/java/docs/javadsl/XmlParsingTest.java
@@ -103,27 +103,28 @@ public class XmlParsingTest {
StringBuilder::new,
(textBuffer, parseEvent) -> {
// aggregation function
- switch (parseEvent.marker()) {
- case XMLStartElement:
+ return switch (parseEvent.marker()) {
+ case XMLStartElement -> {
textBuffer.delete(0, textBuffer.length());
- return Pair.create(textBuffer, Optional.<String>empty());
- case XMLEndElement:
+ yield Pair.create(textBuffer, Optional.<String>empty());
+ }
+ case XMLEndElement -> {
EndElement s = (EndElement) parseEvent;
- switch (s.localName()) {
- case "elem":
+ yield switch (s.localName()) {
+ case "elem" -> {
String text = textBuffer.toString();
- return Pair.create(textBuffer, Optional.of(text));
- default:
- return Pair.create(textBuffer,
Optional.<String>empty());
- }
- case XMLCharacters:
- case XMLCData:
+ yield Pair.create(textBuffer, Optional.of(text));
+ }
+ default -> Pair.create(textBuffer,
Optional.<String>empty());
+ };
+ }
+ case XMLCharacters, XMLCData -> {
TextEvent t = (TextEvent) parseEvent;
textBuffer.append(t.text());
- return Pair.create(textBuffer, Optional.<String>empty());
- default:
- return Pair.create(textBuffer, Optional.<String>empty());
- }
+ yield Pair.create(textBuffer, Optional.<String>empty());
+ }
+ default -> Pair.create(textBuffer,
Optional.<String>empty());
+ };
},
textBuffer -> Optional.of(Optional.of(textBuffer.toString())))
.via(Flow.flattenOptional())
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
