This is an automated email from the ASF dual-hosted git repository.
He-Pin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pekko.git
The following commit(s) were added to refs/heads/main by this push:
new 4c4d0b7665 refactor: replace .collect(Collectors.toList()) with
.toList() (#3189)
4c4d0b7665 is described below
commit 4c4d0b766533faeee89eec355381627dd50d7a17
Author: He-Pin(kerr) <[email protected]>
AuthorDate: Fri Jun 26 21:05:41 2026 +0800
refactor: replace .collect(Collectors.toList()) with .toList() (#3189)
* refactor: replace .collect(Collectors.toList()) with .toList()
Motivation:
Java 16+ Stream.toList() provides a concise way to collect stream
elements into an unmodifiable list.
Modification:
Replace .collect(Collectors.toList()) with .toList() across 39 files.
Remove unused Collectors imports.
Result:
Cleaner stream collection code using Java 17 API.
Tests:
Not run - compile-only test file changes
References:
None - Java 17 API modernization
* refactor: replace remaining .collect(Collectors.toList()) with .toList()
in AggregatorTest
Motivation:
Follow-up to complete Stream.toList() migration.
Modification:
Replace .collect(Collectors.toList()) with .toList() in AggregatorTest.
Remove unused Collectors import.
Result:
Complete migration of JDK Stream collect patterns.
Tests:
Not run - compile-only test file changes
References:
None - Java 17 API modernization
* chore: remove accidentally committed .qoder worktree references
Remove .qoder/worktrees/* submodule references that were accidentally
included in a previous commit.
* javafmt
---------
Co-authored-by: PJ Fanning <[email protected]>
---
.../test/java/jdocs/org/apache/pekko/typed/AggregatorTest.java | 3 +--
docs/src/test/java/jdocs/stream/RateTransformationDocTest.java | 5 ++---
.../jdocs/stream/javadsl/cookbook/RecipeMultiGroupByTest.java | 8 ++------
.../java/org/apache/pekko/stream/io/SinkAsJavaSourceTest.java | 3 +--
.../src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java | 2 +-
.../src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java | 2 +-
6 files changed, 8 insertions(+), 15 deletions(-)
diff --git
a/actor-typed-tests/src/test/java/jdocs/org/apache/pekko/typed/AggregatorTest.java
b/actor-typed-tests/src/test/java/jdocs/org/apache/pekko/typed/AggregatorTest.java
index b45c612096..70e0eed6f6 100644
---
a/actor-typed-tests/src/test/java/jdocs/org/apache/pekko/typed/AggregatorTest.java
+++
b/actor-typed-tests/src/test/java/jdocs/org/apache/pekko/typed/AggregatorTest.java
@@ -25,7 +25,6 @@ import java.util.Arrays;
import java.util.List;
import java.util.function.Consumer;
import java.util.function.Function;
-import java.util.stream.Collectors;
import org.apache.pekko.actor.testkit.typed.annotations.JUnitJupiterTestKit;
import org.apache.pekko.actor.testkit.typed.javadsl.ActorTestKit;
import org.apache.pekko.actor.testkit.typed.javadsl.JUnitJupiterTestKitBuilder;
@@ -159,7 +158,7 @@ public class AggregatorTest {
}
})
.sorted((a, b) -> a.price().compareTo(b.price()))
- .collect(Collectors.toList());
+ .toList();
return new AggregatedQuotes(quotes);
}
diff --git a/docs/src/test/java/jdocs/stream/RateTransformationDocTest.java
b/docs/src/test/java/jdocs/stream/RateTransformationDocTest.java
index 824b742fe5..64cd44ac1e 100644
--- a/docs/src/test/java/jdocs/stream/RateTransformationDocTest.java
+++ b/docs/src/test/java/jdocs/stream/RateTransformationDocTest.java
@@ -20,7 +20,6 @@ import java.util.Collections;
import java.util.List;
import java.util.concurrent.CompletionStage;
import java.util.concurrent.TimeUnit;
-import java.util.stream.Collectors;
import java.util.stream.DoubleStream;
import java.util.stream.Stream;
import jdocs.AbstractJavaTest;
@@ -71,7 +70,7 @@ public class RateTransformationDocTest extends
AbstractJavaTest {
elem -> Collections.singletonList(elem),
(acc, elem) -> {
return Stream.concat(acc.stream(),
Collections.singletonList(elem).stream())
- .collect(Collectors.toList());
+ .toList();
})
.map(
s -> {
@@ -103,7 +102,7 @@ public class RateTransformationDocTest extends
AbstractJavaTest {
(acc, elem) -> {
if (r.nextDouble() < p) {
return Stream.concat(acc.stream(),
Collections.singletonList(elem).stream())
- .collect(Collectors.toList());
+ .toList();
}
return acc;
})
diff --git
a/docs/src/test/java/jdocs/stream/javadsl/cookbook/RecipeMultiGroupByTest.java
b/docs/src/test/java/jdocs/stream/javadsl/cookbook/RecipeMultiGroupByTest.java
index 289839ab26..1dac06167c 100644
---
a/docs/src/test/java/jdocs/stream/javadsl/cookbook/RecipeMultiGroupByTest.java
+++
b/docs/src/test/java/jdocs/stream/javadsl/cookbook/RecipeMultiGroupByTest.java
@@ -13,7 +13,6 @@
package jdocs.stream.javadsl.cookbook;
-import static java.util.stream.Collectors.toList;
import static org.junit.jupiter.api.Assertions.assertTrue;
import java.util.ArrayList;
@@ -111,7 +110,7 @@ public class RecipeMultiGroupByTest extends RecipeTest {
// the message belongs to
return topicsForMessage.stream()
.map(topic -> new Pair<Message, Topic>(msg, topic))
- .collect(toList());
+ .toList();
});
SubSource<Pair<Message, Topic>, NotUsed> multiGroups =
@@ -138,10 +137,7 @@ public class RecipeMultiGroupByTest extends RecipeTest {
Topic topic = pair.get(0).second();
return topic.name
+ mkString(
- pair.stream().map(p ->
p.first().msg).collect(toList()),
- "[",
- ", ",
- "]");
+ pair.stream().map(p -> p.first().msg).toList(),
"[", ", ", "]");
})
.grouped(10)
.runWith(Sink.head(), system);
diff --git
a/stream-tests/src/test/java/org/apache/pekko/stream/io/SinkAsJavaSourceTest.java
b/stream-tests/src/test/java/org/apache/pekko/stream/io/SinkAsJavaSourceTest.java
index 9b6fcf7051..a6677997fd 100644
---
a/stream-tests/src/test/java/org/apache/pekko/stream/io/SinkAsJavaSourceTest.java
+++
b/stream-tests/src/test/java/org/apache/pekko/stream/io/SinkAsJavaSourceTest.java
@@ -17,7 +17,6 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
import java.util.Arrays;
import java.util.List;
-import java.util.stream.Collectors;
import java.util.stream.Stream;
import org.apache.pekko.stream.StreamTestJupiter;
import org.apache.pekko.stream.javadsl.Sink;
@@ -43,6 +42,6 @@ public class SinkAsJavaSourceTest extends StreamTestJupiter {
final List<Integer> list = Arrays.asList(1, 2, 3);
final Sink<Integer, Stream<Integer>> streamSink =
StreamConverters.asJavaStream();
java.util.stream.Stream<Integer> javaStream =
Source.from(list).runWith(streamSink, system);
- assertEquals(list, javaStream.collect(Collectors.toList()));
+ assertEquals(list, javaStream.toList());
}
}
diff --git
a/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java
b/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java
index 7dd153b278..39c6a791b1 100644
--- a/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java
+++ b/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/FlowTest.java
@@ -501,7 +501,7 @@ public class FlowTest extends StreamTestJupiter {
final List<List<String>> result =
future.toCompletableFuture().get(1, TimeUnit.SECONDS).stream()
.sorted(Comparator.comparingInt(list -> list.get(0).charAt(0)))
- .collect(Collectors.toList());
+ .toList();
assertEquals(
Arrays.asList(
diff --git
a/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java
b/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java
index db3341baea..6fd151ba8b 100644
--- a/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java
+++ b/stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java
@@ -266,7 +266,7 @@ public class SourceTest extends StreamTestJupiter {
final List<List<String>> result =
future.toCompletableFuture().get(1, TimeUnit.SECONDS).stream()
.sorted(Comparator.comparingInt(list -> list.get(0).charAt(0)))
- .collect(Collectors.toList());
+ .toList();
assertEquals(
Arrays.asList(
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
