sunithabeeram commented on a change in pull request #3834: Unify move method in
PinotFS
URL: https://github.com/apache/incubator-pinot/pull/3834#discussion_r258153180
##########
File path:
pinot-hadoop-filesystem/src/main/java/org/apache/pinot/filesystem/HadoopPinotFS.java
##########
@@ -92,9 +92,25 @@ public boolean delete(URI segmentUri, boolean forceDelete)
@Override
public boolean move(URI srcUri, URI dstUri, boolean overwrite)
throws IOException {
- if (exists(dstUri) && !overwrite) {
+ if (!exists(srcUri)) {
Review comment:
This part of the code exists in all implementations. Can we add this to
PinotFS, call super.move() and then handle FS specific logic in the impl
classes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
