sunithabeeram commented on a change in pull request #3834: Unify move method in
PinotFS
URL: https://github.com/apache/incubator-pinot/pull/3834#discussion_r260408619
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -170,8 +170,8 @@ public static URI getUriFromPath(String path) {
public static URI constructSegmentLocation(String baseDataDir, String
tableName, String segmentName) {
try {
- return new URI(StringUtil.join(File.separator, baseDataDir, tableName,
URLEncoder.encode(segmentName, "UTF-8")));
- } catch (UnsupportedEncodingException | URISyntaxException e) {
+ return getUriFromPath(StringUtil.join(File.separator, baseDataDir,
tableName, URLEncoder.encode(segmentName, "UTF-8")));
Review comment:
Is this change related to this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
