codecov-io edited a comment on issue #3885: Actively check cluster changes if there is no callback for a long time URL: https://github.com/apache/incubator-pinot/pull/3885#issuecomment-467268993 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=h1) Report > Merging [#3885](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9269f5e02cfd868bd9448c6c4df9107e5776e60c?src=pr&el=desc) will **increase** coverage by `0.09%`. > The diff coverage is `87.91%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3885 +/- ## ============================================ + Coverage 67.12% 67.22% +0.09% Complexity 4 4 ============================================ Files 1030 1032 +2 Lines 50829 50844 +15 Branches 7102 7101 -1 ============================================ + Hits 34121 34181 +60 + Misses 14369 14336 -33 + Partials 2339 2327 -12 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQ29ubmVjdGlvblBvb2xCcm9rZXJSZXF1ZXN0SGFuZGxlci5qYXZh) | `88.27% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...broker/broker/helix/ExternalViewChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0V4dGVybmFsVmlld0NoYW5nZUhhbmRsZXIuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...a/org/apache/pinot/common/metrics/BrokerTimer.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJUaW1lci5qYXZh) | `88.88% <100%> (+1.38%)` | `0 <0> (ø)` | :arrow_down: | | [...oker/broker/helix/InstanceConfigChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0luc3RhbmNlQ29uZmlnQ2hhbmdlSGFuZGxlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...a/org/apache/pinot/common/metrics/BrokerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJNZXRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pache/pinot/broker/broker/BrokerServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jyb2tlclNlcnZlckJ1aWxkZXIuamF2YQ==) | `91.07% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `73.5% <100%> (+1.18%)` | `0 <0> (ø)` | :arrow_down: | | [...broker/broker/helix/LiveInstanceChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0xpdmVJbnN0YW5jZUNoYW5nZUhhbmRsZXIuamF2YQ==) | `65.9% <75%> (ø)` | `0 <0> (?)` | | | [...not/broker/broker/helix/ClusterChangeMediator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0NsdXN0ZXJDaGFuZ2VNZWRpYXRvci5qYXZh) | `82.14% <84.78%> (+19.84%)` | `0 <0> (ø)` | :arrow_down: | | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | | | ... and [37 more](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=footer). Last update [9269f5e...6700ac5](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
