codecov-io edited a comment on issue #3885: Actively check cluster changes if there is no callback for a long time URL: https://github.com/apache/incubator-pinot/pull/3885#issuecomment-467268993 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=h1) Report > Merging [#3885](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/6fc48ce5cf44fa4e2bec55a6848efd3e468676a4?src=pr&el=desc) will **increase** coverage by `6.66%`. > The diff coverage is `75.92%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3885 +/- ## ============================================ + Coverage 60.45% 67.11% +6.66% Complexity 4 4 ============================================ Files 1153 1032 -121 Lines 57766 50865 -6901 Branches 8012 7105 -907 ============================================ - Hits 34920 34140 -780 + Misses 20419 14382 -6037 + Partials 2427 2343 -84 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQ29ubmVjdGlvblBvb2xCcm9rZXJSZXF1ZXN0SGFuZGxlci5qYXZh) | `88.27% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...broker/broker/helix/ExternalViewChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0V4dGVybmFsVmlld0NoYW5nZUhhbmRsZXIuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...a/org/apache/pinot/common/metrics/BrokerTimer.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJUaW1lci5qYXZh) | `88.88% <100%> (+1.38%)` | `0 <0> (ø)` | :arrow_down: | | [...oker/broker/helix/InstanceConfigChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0luc3RhbmNlQ29uZmlnQ2hhbmdlSGFuZGxlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...a/org/apache/pinot/common/metrics/BrokerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJNZXRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pache/pinot/broker/broker/BrokerServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jyb2tlclNlcnZlckJ1aWxkZXIuamF2YQ==) | `91.07% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...not/broker/broker/helix/ClusterChangeMediator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0NsdXN0ZXJDaGFuZ2VNZWRpYXRvci5qYXZh) | `65.15% <63.79%> (+2.85%)` | `0 <0> (ø)` | :arrow_down: | | [...broker/broker/helix/LiveInstanceChangeHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0xpdmVJbnN0YW5jZUNoYW5nZUhhbmRsZXIuamF2YQ==) | `65.9% <75%> (ø)` | `0 <0> (?)` | | | [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `73.1% <92.85%> (+0.78%)` | `0 <0> (ø)` | :arrow_down: | | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `20.28% <0%> (-59.43%)` | `0% <0%> (ø)` | | | ... and [152 more](https://codecov.io/gh/apache/incubator-pinot/pull/3885/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=footer). Last update [6fc48ce...549d0c6](https://codecov.io/gh/apache/incubator-pinot/pull/3885?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
