Jackie-Jiang commented on a change in pull request #3864: Add controller mode
logic in ControllerStarter
URL: https://github.com/apache/incubator-pinot/pull/3864#discussion_r261018053
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -142,7 +145,8 @@
public PinotHelixResourceManager(@Nonnull String zkURL, @Nonnull String
helixClusterName,
@Nonnull String controllerInstanceId, String dataDir, long
externalViewOnlineToOfflineTimeoutMillis,
- boolean isSingleTenantCluster, boolean isUpdateStateModel, boolean
enableBatchMessageMode) {
+ boolean isSingleTenantCluster, boolean isUpdateStateModel, boolean
enableBatchMessageMode,
+ String controllerMode) {
Review comment:
I would recommend separate the Helix Controller out of
PinotHelixResourceManager. PinotHelixResourceManager always join as the
ADMINISTRATOR. The controllerMode should be handled in the upper layer, and the
PinotHelixResourceManager should serve only as Pinot Controller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
