Jackie-Jiang commented on a change in pull request #3864: Add controller mode 
logic in ControllerStarter
URL: https://github.com/apache/incubator-pinot/pull/3864#discussion_r261012203
 
 

 ##########
 File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
 ##########
 @@ -582,4 +585,14 @@ public void setStatusCheckerInitialDelayInSeconds(long 
initialDelayInSeconds) {
   public long getPeriodicTaskInitialDelayInSeconds() {
     return ControllerPeriodicTasksConf.getRandomInitialDelayInSeconds();
   }
+
+  public void setControllerMode(String controllerMode) {
 
 Review comment:
   Pass in HelixSetupUtils.ControllerMode instead of String?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to