snleee commented on a change in pull request #3869: add config to control kafka
fetcher size and increase default
URL: https://github.com/apache/incubator-pinot/pull/3869#discussion_r261506988
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/kafka/KafkaStreamConfigProperties.java
##########
@@ -43,9 +43,12 @@
public static class LowLevelConsumer {
public static final String KAFKA_BROKER_LIST = "kafka.broker.list";
public static final String KAFKA_BUFFER_SIZE = "kafka.buffer.size";
- public static final int KAFKA_BUFFER_SIZE_DEFAULT = 512000;
+ public static final int KAFKA_BUFFER_SIZE_DEFAULT = 5120000;
Review comment:
I can see that increasing buffer size will enable Pinot to fetch larger
messages. Other than that, what is the impact of increasing buffer? I guess
that it will increase the throughput but may impact on latency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
