This is an automated email from the ASF dual-hosted git repository.
sunithabeeram pushed a commit to branch contrib
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/contrib by this push:
new 9139e0b Add info about travis
9139e0b is described below
commit 9139e0b0fd082f81315eb054050f9b18dcf9d4ae
Author: Sunitha Beeram <[email protected]>
AuthorDate: Thu Mar 7 08:37:39 2019 -0800
Add info about travis
---
docs/contribution_guidelines.rst | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/docs/contribution_guidelines.rst b/docs/contribution_guidelines.rst
index 273fe87..5fd2fe1 100644
--- a/docs/contribution_guidelines.rst
+++ b/docs/contribution_guidelines.rst
@@ -172,7 +172,10 @@ After this, create a PullRequest in `github
<https://github.com/apache/incubator
* Evidence of sufficient testing. You ``MUST`` indicate the tests done, either
manually or automated.
-Request reviews from atleast 2 committers on the project and be sure to gently
to followup on the issue with the reviewers.
+Once the PR is created, the code base is compiled and all tests are run via
``travis``. Make sure you followup on any issues flagged by travis and address
them.
+If you see test failures that are intermittent, ``please`` create an issue to
track them.
+
+Once the ``travis`` run is clear, request reviews from atleast 2 committers on
the project and be sure to gently to followup on the issue with the reviewers.
* Addressing comments and Rebasing
Once you receive comments on github on your changes, be sure to respond to
them on github and address the concerns.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
