mcvsubbu commented on a change in pull request #3877: Pinot controller side
change to enhance LLC segment metadata upload.
URL: https://github.com/apache/incubator-pinot/pull/3877#discussion_r263463195
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java
##########
@@ -236,9 +258,18 @@ public String
segmentCommit(@QueryParam(SegmentCompletionProtocol.PARAM_INSTANCE
SegmentCompletionProtocol.Response response =
segmentCompletionManager.segmentCommitStart(requestParams);
if (response.equals(SegmentCompletionProtocol.RESP_COMMIT_CONTINUE)) {
// Get the segment and put it in the right place.
- boolean success = uploadSegment(multiPart, instanceId, segmentName,
false) != null;
+ ImmutablePair<URI, SegmentMetadataImpl> uploadResult =
uploadSegment(multiPart, instanceId, segmentName, false);
+ boolean success = (uploadResult != null && uploadResult.getLeft() !=
null && uploadResult.getRight() != null);
+ SegmentMetadataImpl segmentMetadata = null;
Review comment:
we can fail the commit if segment metadata is null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
