mcvsubbu commented on a change in pull request #3941: Pinot server side change
to optimize LLC segment completion with direct metadata upload.
URL: https://github.com/apache/incubator-pinot/pull/3941#discussion_r265382130
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/LLCRealtimeClusterSplitCommitEndWithMetadataTest.java
##########
@@ -0,0 +1,27 @@
+package org.apache.pinot.integration.tests;
+
+import org.apache.commons.configuration.Configuration;
+import org.apache.pinot.common.utils.CommonConstants;
+import org.apache.pinot.controller.ControllerConf;
+
+/**
+ * Integration test that extends LLCRealtimeClusterIntegrationTest but with
split commit enabled and segment commit end
+ * with metadata file upload enabled.
+ */
+public class LLCRealtimeClusterSplitCommitEndWithMetadataTest extends
LLCRealtimeClusterIntegrationTest {
Review comment:
Instead of adding a new test (that increases test time), we can just change
the split commit test to just use the new controller endpoint to commit with
metadata. We should deprecate the one that commits without metadata, since this
one is far superior. The only reason to use the other one is for backward
compat for one release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
