mcvsubbu commented on a change in pull request #3941: Pinot server side change
to optimize LLC segment completion with direct metadata upload.
URL: https://github.com/apache/incubator-pinot/pull/3941#discussion_r267074696
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -735,7 +765,13 @@ protected SegmentBuildDescriptor
buildSegmentInternal(boolean forCommit) {
if (_isOffHeap) {
params.withMemoryUsedBytes(_memoryManager.getTotalAllocatedBytes());
}
- SegmentCompletionProtocol.Response commitEndResponse =
_protocolHandler.segmentCommitEnd(params);
+ SegmentCompletionProtocol.Response commitEndResponse;
+ if (!_indexLoadingConfig.isEnableSplitCommitEndWithMetadata()) {
Review comment:
nit I would prefer the condition inverted, given that both if and else
portions are one line long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
