mcvsubbu commented on a change in pull request #4025: Extend stream interfaces
to expose message metadata like ingestion timestamp
URL: https://github.com/apache/incubator-pinot/pull/4025#discussion_r270247157
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -210,6 +222,11 @@ public boolean index(GenericRow row) {
// Add forward and inverted indices for new document.
addForwardIndex(row, docId, dictIdMap);
addInvertedIndex(docId, dictIdMap);
+
+ _lastIndexedTimestamp = System.currentTimeMillis();
Review comment:
You also need to update it before the return in line 236 since we are
aggregating the metrics there. Not sure if aggregateMetrics() silently skips
aggregation, please verify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
