mcvsubbu commented on a change in pull request #4025: Extend stream interfaces
to expose message metadata like ingestion timestamp
URL: https://github.com/apache/incubator-pinot/pull/4025#discussion_r273567290
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/segment/SegmentMetadata.java
##########
@@ -73,6 +73,23 @@
*/
long getRefreshTime();
+ // methods specific to realtime segments
Review comment:
I would prefer adding this comment to each of the comment block below.
Otherwise, it seems as if the comment is valid for all methods below this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
