sunithabeeram commented on a change in pull request #3979: Track "freshness"
timestamp across consuming segments
URL: https://github.com/apache/incubator-pinot/pull/3979#discussion_r281033725
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/IndexSegment.java
##########
@@ -29,6 +29,15 @@
@InterfaceAudience.Private
public interface IndexSegment {
+ public enum IndexSegmentType{
Review comment:
I don't think I agree with this. Exposing a type is a much cleaner way of
handling this than doing instanceOf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
