sunithabeeram commented on a change in pull request #3979: Track "freshness"
timestamp across consuming segments
URL: https://github.com/apache/incubator-pinot/pull/3979#discussion_r281033984
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/stream/StreamLevelConsumer.java
##########
@@ -47,10 +48,9 @@ void start()
/**
* Get next row from the stream and decode it into a generic row
* @param destination the decoded generic row
- * @param metadata the metadata associated with the decoded stream if any
* @return the decoded generic row
*/
- default GenericRow next(GenericRow destination, StreamMessageMetadata
metadata) {
+ default GenericRow next(GenericRow destination, RowMetadata metadata) {
Review comment:
I wanted plumb-in the implementation for both HLC and LLC - so its less
confusing in the future. Given there is no specific use case for this now, I
will drop it - once things look good with LLC, I might update the interface to
make both support similar functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
