mcvsubbu commented on a change in pull request #4193: Creation/deletion flow
for replica groups sets in realtime
URL: https://github.com/apache/incubator-pinot/pull/4193#discussion_r282194953
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/partition/ReplicaGroupPartitionAssignmentGenerator.java
##########
@@ -99,7 +103,11 @@ public ReplicaGroupPartitionAssignment
buildReplicaGroupPartitionAssignment(Stri
numColumnPartitions =
tableConfig.getIndexingConfig().getSegmentPartitionConfig().getNumPartitions(partitionColumn);
}
- int numReplicas = tableConfig.getValidationConfig().getReplicationNumber();
+
+ TableType tableType = tableConfig.getTableType();
+ int numReplicas =
Review comment:
The code in PinotTableRestletResource.ensureMinReplicas() handles the case
of HLC and LLC correctly to get the number of replicas for realtime. Not sure
if that code can be pulled up to some common area (since it includes some
verify flags as well), but it will be good if we do so.
I suppose there is some way this code is not enabled for HLC?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
